fix: cid for filecoin offer must be raw #1450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vasco-santos
force-pushed
the
fix/cid-for-filecoin-offer-must-be-raw
branch
from
28d1acf
to
14a39ac
Compare
alanshaw
approved these changes
May 14, 2024
vasco-santos
force-pushed
the
fix/cid-for-filecoin-offer-must-be-raw
branch
3 times, most recently
from
c139b75
to
0659a4c
Compare
The blob index logic should be an independent module as it will be used in both client and service code. --------- Co-authored-by: Alan Shaw <alan.shaw@protocol.ai>
vasco-santos
force-pushed
the
fix/cid-for-filecoin-offer-must-be-raw
branch
from
0659a4c
to
ca8e7a3
Compare
vasco-santos
commented
May 14, 2024
| @@ -134,12 +134,15 @@ async function uploadBlockStream( | |||
| const bytes = new Uint8Array(await car.arrayBuffer()) | |||
| // Invoke blob/add and write bytes to write target | |||
| const multihash = await Blob.add(conf, bytes, options) | |||
| // Should this be raw instead? | |||
There was a problem hiding this comment.
Suggested change
| // Should this be raw instead? |
travis
added a commit
that referenced
this pull request
May 14, 2024
🤖 I have created a release *beep* *boop* --- ## [14.1.0](upload-client-v14.0.0...upload-client-v14.1.0) (2024-05-14) ### Features * add blob protocol to upload-client ([#1425](#1425)) ([49aef56](49aef56)) ### Fixes * cid for filecoin offer must be raw ([#1450](#1450)) ([c3dd7b5](c3dd7b5)) ### Other Changes * appease linter ([782c6d0](782c6d0)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Travis Vachon <travis.vachon@protocol.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we previously decided,
filecoin/offershould receive raw CIDs #1408 (comment) so that everything works out of the box and Blobs can be read from roundabout for validation + from SPs