Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Avoid conflation of Space and Account #1545

Merged
merged 2 commits into from
Oct 11, 2024
Merged

refactor: Avoid conflation of Space and Account #1545

merged 2 commits into from
Oct 11, 2024

Commits on Sep 6, 2024

  1. refactor: Avoid conflation of Space and Account 

    * `space.signer.withDID(account)` gives us a Signer with the Space's
  key, but which reports the Account's DID. It looks like this might
  have been needed at some point when this thing was actually used to
  sign something. But as of now, we don't need a *Signer*, just a DID,
  and a `did:mailto:` is fine. So, simplify this.

* This was being passed as the `agent`, but it's not an Agent.
  `createAuthorization()` doesn't need an Agent, it needs an *audience*.
  In some cases that's an Agent, in some cases it's an Account. This
  changes the name to clarify.
    @Peeja
    Peeja committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    1728a4c View commit details
    Browse the repository at this point in the history

  2. chore: Don't specify version in workflow 

    We already have it in `packageManager`.
    @Peeja
    Peeja committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    12e0489 View commit details
    Browse the repository at this point in the history