fix: re-enable upload-api tests #864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mocha's globbing behavior is... quirky. tests currently broken, working to fix.
alanshaw
approved these changes
Aug 17, 2023
I still can't really figure out why, but "equal" CIDs suddenly stopped comparing equally with `deepEqual` - we were already converting them to strings in at least one place, so do that in the remaining spots.
|
chatted w/ @alanshaw out of band on the test changes I made after approval and I think we're aligned - want to get this merged to get tests running again on main but happy to update from any post-merge comments! |
travis
added a commit
that referenced
this pull request
Aug 22, 2023
🤖 I have created a release *beep* *boop* --- ## [5.1.0](upload-api-v5.0.0...upload-api-v5.1.0) (2023-08-22) ### Features * add providers to space/info ([#862](#862)) ([ac72921](ac72921)) * add subscriptions to CustomerGetSuccess ([#863](#863)) ([dd2e77c](dd2e77c)) * change "total" to "limit" ([#867](#867)) ([8295070](8295070)) ### Bug Fixes * re-enable upload-api tests ([#864](#864)) ([d76a6af](d76a6af)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: Travis Vachon <travis.vachon@protocol.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mocha's globbing behavior is... quirky. tests currently broken, working to fix.