fix: defensive code around container logic (#16)

stordco · Jun 5, 2023 · 97d770b · 97d770b
1 parent 03b55c3
commit 97d770b
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/lib/datadog/data_streams/container.ex b/lib/datadog/data_streams/container.ex
@@ -49,7 +49,7 @@ defmodule Datadog.DataStreams.Container do
     file
     |> File.stream!()
     |> parse_container_id()
-  catch
+  rescue
     _ -> nil
   end
 
@@ -61,7 +61,7 @@ defmodule Datadog.DataStreams.Container do
     |> Stream.map(&parse_line/1)
     |> Stream.filter(fn value -> not is_nil(value) end)
     |> Enum.at(0)
-  catch
+  rescue
     _ -> nil
   end
 

diff --git a/test/datadog/data_streams/container_test.exs b/test/datadog/data_streams/container_test.exs
@@ -162,4 +162,8 @@ defmodule Datadog.DataStreams.ContainerTest do
 
     assert ^cid = Container.read_container_id(file_path)
   end
+
+  test "read_container_id/1 does not fail when file does not exist" do
+    refute Container.read_container_id("/does/not/exist/ohpleasedontbreakmytests")
+  end
 end