Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: defensive code around container logic #16

Merged
merged 1 commit into from
Jun 5, 2023
Merged

fix: defensive code around container logic #16

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/datadog/data_streams/container.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ defmodule Datadog.DataStreams.Container do
file
|> File.stream!()
|> parse_container_id()
catch
rescue
_ -> nil
end

Expand All @@ -61,7 +61,7 @@ defmodule Datadog.DataStreams.Container do
|> Stream.map(&parse_line/1)
|> Stream.filter(fn value -> not is_nil(value) end)
|> Enum.at(0)
catch
rescue
_ -> nil
end

Expand Down
4 changes: 4 additions & 0 deletions test/datadog/data_streams/container_test.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,4 +162,8 @@ defmodule Datadog.DataStreams.ContainerTest do

assert ^cid = Container.read_container_id(file_path)
end

test "read_container_id/1 does not fail when file does not exist" do
refute Container.read_container_id("/does/not/exist/ohpleasedontbreakmytests")
end
end