Skip to content

Commit

Permalink
non-static Android database runner map
Browse files Browse the repository at this point in the history
(POTENTIALLY BREAKING CHANGE)

ref: #763
  • Loading branch information
Christopher J. Brody committed Jan 29, 2019
1 parent e1d46c3 commit 5c19a45
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
1 change: 1 addition & 0 deletions CHANGES.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

###### cordova-sqlite-storage-ext-core-common 1.0.1-dev

- non-static Android database runner map (POTENTIALLY BREAKING CHANGE)
- Completely remove old Android SuppressLint (android.annotation.SuppressLint) - POSSIBLY BREAKING CHANGE
- drop workaround for pre-Honeycomb Android API (BREAKING CHANGE)
- no extra @synchronized block per batch (iOS/macOS) - should be considered a POSSIBLY BREAKING change
Expand Down
4 changes: 2 additions & 2 deletions src/android/io/sqlc/SQLitePlugin.java
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
public class SQLitePlugin extends CordovaPlugin {

/**
* Multiple database runner map (static).
* Concurrent database runner map.
*
* NOTE: no public static accessor to db (runner) map since it is not
* expected to work properly with db threading.
Expand All @@ -42,7 +42,7 @@ public class SQLitePlugin extends CordovaPlugin {
* THANKS to @NeoLSN (Jason Yang/楊朝傑) for giving the pointer in:
* https://github.com/litehelpers/Cordova-sqlite-storage/issues/727
*/
static Map<String, DBRunner> dbrmap = new ConcurrentHashMap<String, DBRunner>();
private Map<String, DBRunner> dbrmap = new ConcurrentHashMap<String, DBRunner>();

/**
* NOTE: Using default constructor, no explicit constructor.
Expand Down

0 comments on commit 5c19a45

Please sign in to comment.