-
Notifications
You must be signed in to change notification settings - Fork 714
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wp8 converts to negative too big integers #195
Comments
Thanks for reporting this! |
Fixes: - #193: workaround for Android db locking/closing issue - #144: convert array parameters to string to match Web SQL - #199: fix double-precision REAL values in result for iOS version - #150/#153: close Android db before removing from map - Fix truncation in iOS query result in case of UNICODE NULL (\0 or \u0000) (ref: PR #170) - Some fixes for error handling to be consistent with Web SQL (ref: PR #170) Testing ONLY: - #147: testing with UNICODE line separator - #195: Reproduce issue with double-precision REAL number on WP(8) ONLY
Fixes: - #193: workaround for Android db locking/closing issue - #144: convert array parameters to string to match Web SQL - #199: fix double-precision REAL values in result for iOS version - #150/#153: close Android db before removing from map - Fix truncation in iOS query result in case of UNICODE NULL (\0 or \u0000) (ref: PR #170) - Some fixes for error handling to be consistent with Web SQL (ref: PR #170) Testing ONLY: - #147: testing with UNICODE line separator - #195: Reproduce issue with double-precision REAL number on WP(8) ONLY
Hi, I have the same Issue, Do you know some workariund to fix it? When It will be fixed? |
Hi there. At the moment I have no solution, I just convert the numbers at app level. Cheers. Javier On 14 December 2015 at 09:36, martatw notifications@github.com wrote:
|
Hi, After deeper investigation, I have found out that plugin correnctly is adding int64 to DB. However the bug occured after getting data from BD. There is a code in wp\SQLite.cs : line: 1958; function ExecuteDeferredQuery():
Each Integer data is converted to int32. After changing to Int64 it works fine. Do You think that this change might have some negative inpact? (I am speaking about windows Phone 8.1 app) BR |
Thanks @martatw! A pull request for this would be really helpful (I cannot try this change until I return from vacation in January). |
When I tried diff --git a/src/wp/SQLite.cs b/src/wp/SQLite.cs
index f1b96c2..268d569 100644
--- a/src/wp/SQLite.cs
+++ b/src/wp/SQLite.cs
@@ -1958,8 +1958,6 @@ namespace SQLite
targetType = typeof(string);
break;
case SQLite3.ColType.Integer:
- targetType = typeof(int);
- break;
case SQLite3.ColType.Float:
targetType = typeof(double);
break; |
Issue
When I do a select of a too big integer value, wp8 converts it to a negative value, in this example "-1754182378_"
Sqlite table
CREATE TABLE INFO(last_sync_date INTEGER);
INSERT INTO "INFO" VALUES(1424174959894);
Software versions:
Cordova -> 3.6.3-0.2.13
wp8 -> Windows Phone 8.1 update
Sqlite plugin -> 1.0.4
Snippet of code:
The text was updated successfully, but these errors were encountered: