-
Notifications
You must be signed in to change notification settings - Fork 714
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CREATE database if it does not exist should be optional #212
Comments
It would be ideal to keep the API as consistent as possible with the following:
I am thinking of adding an option such as An alternative idea discussed in #401 is to add an openDatabase creation callback according to the Web SQL API. I think it would add extra, unneeded complexity ADDITIONAL NOTE: the openDatabase creation callback would add extra complexity to higher level libraries such as Ionic-native & https://github.com/nolanlawson/pouchdb-adapter-cordova-sqlite, and it may cause problems with pre-populated database options discussed in storesafe/cordova-sqlite-storage-help#26 as well. NOT DESIRED. |
I would like to also address some discussion points in danielsogl/awesome-cordova-plugins#881: From danielsogl/awesome-cordova-plugins#881 (comment) by @cocowalla:
Agreed on my part. From danielsogl/awesome-cordova-plugins#881 (comment) by @cocowalla:
Nice idea but I would not favor it. In general I think this plugin should have a single openDatabase entry point where the options may be passed down from higher level application code and libraries such as Ionic-native and pouchdb-adapter-cordova-sqlite. As I said above my idea is to add an option such as ADDITIONAL COMMENT: I would like to keep the API as consistent as possible with other SQLite APIs as discussed in the comment above. I will probably need at least 1-2 months to clear my backlog before resolving this one. |
@brodybits your alternative using an option sounds fine too, although its not immediately clear to me what the meaning of |
ADDITIONAL NOTE(S):
The text was updated successfully, but these errors were encountered: