-
Notifications
You must be signed in to change notification settings - Fork 714
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upcoming minor release items #685
Comments
@brodybits there is any update on the timeline for this release? I'm interested particularly in the fix for the issue #563 Thanks |
My apologies for the delay that was due to workload. I will probably need another 1-2 months and may combine with major release in #687. @jabawack81 workaround for #563 is to fix it yourself in a fork or with help from npmjs.com / patch-package. |
@brodybits I would love to if I knew what to fix. |
@jabawack81 the /SAFESEH build flag for Win32 is now integrated with this plugin version as well as cordova-sqlite-ext. Please report if it helps or not. |
cordova-sqlite-storage 2.1.0 & 2.1.1 released with some changes discussed here:
along with a couple additional changes from pull requests:
|
I Brody I got the same error. My test procedure:
and got this error:
|
@jabawack81 I just updated https://github.com/brodybits/cordova-sqlite-storage-starter-app and was able to create a Windows app package from project -> store -> create app packages (with a test certificate, I did not create the app package for the app store but this part should not matter). In general
|
Hi guys, any news about next release? I get bug on Windows 10 #709 |
Is there any plan or possibility that spatialite will be integrated or can be used with any of supported plugin versions? |
Spatialite is already discussed in storesafe/cordova-sqlite-storage-help#32. |
At this point I am giving top priority to a newly redesigned plugin version which is in progress at this time, discussed in brodycj/ask-me-anything#3. Priority for other items is given to paid customers. Please feel free to reach out to chris.brody+brodybits@gmail.com or sales@xpbrew.com in case of interest. |
Minor release
Mandatory
ADDITIONAL (GENERAL):
Workaround solutions for iOS/macOS data loss risk issues:DONEcompile withDONESQLITE_THREADSAFE=2
again ref: Database malformation #703workaround solution for iOS threading issue reported in iOS threading issue with openDatabase? #716DONEAddDONE/SAFESH
as described in:Open Database fails on Windows 10 Release Build [Store -> Create app packages] #563 (comment)https://msdn.microsoft.com/en-us/library/9a89h429.aspxDocumentation
ADDITIONAL:
Note that standard transaction mechanism is no longer recommended and to be deprecated ref: Deprecate standard transaction mechanism in next major release? #690DONEDocument "multiple sqlite problem risk" ref: Possible "Multiple SQLite problem" (corruption problem) on multiple platforms #626DONEFeature(s)
UPDATE: Moved to major release ref: #687 due to time/schedule constraint:
Function to get database directory path ref: Function to get [default] database directory path #680 (may be affected by Database storage in arbitrary path (Android/iOS/macOS/Windows) #681: Database storage in arbitrary path Android/iOS/macOS/Windows)Highly desired
Documentation
Testing
ADDITIONAL:
Fixes & features
UPDATE: these updates are expected to come in the major release ref: #687
ADDITIONAL, HIGHLY DESIRED before major release
now expected to come in the major release ref: #687Use UTF-8 encoding for Windows ref: Use UTF-8 encoding for Windows? #652
TBD better cleanup of "new transaction is waiting for open operation" log messages ref: new transaction is waiting for open operation - before open #679SQLite3 compile options such as HAVE_USLEEP & NDEBUG for closer match to sqlcipher version
Integrate fix contributed in (Windows) added fix to preserve embedded nulls within text data #709 to handle NULL (
u0000
) characters on Windows platformShould refuse to open new database files after
onDestroy
on Android has been called, equivalent on iOS ref: PR Fix ProGuard issue with map.keySet() on Java 8 #697Update needed to work with cordova-android@7 ref: Update to work with cordova-android@7.0.0 #729
builtin android.database end transaction if active before closing (8192bc8) ref:Cordova sqlite express EXPERIMENTAL WIP #730DONEBind all numbers as REAL numbers ref: Bind all numbers as REAL values #684 possibly before major release
TBD (possibly related to Bind all numbers as REAL values #684): builtin android.database implementation seems to treat numeric parameter argument values as string values, needs investigation ref: Cordova sqlite express EXPERIMENTAL WIP #730 (comment)
TBD for investigation: PRAGMA journal_mode should be same value on builtin android.database implementation, default Android-sqlite-connector implementation, and other platforms ref: Cordova sqlite express EXPERIMENTAL WIP #730 (comment)WILL NOT BE CHANGED: PRAGMA journal_mode reportsdelete
in case of default android.database implementation (same as other platform implementations) on Android 8.1Fix broken Circle/Travis CI or remove
JavaScript remove qid no longer needed & other cleanup
Fix for builtin android.database implementation on Turkish and other foreign locales in PR Fix for turkish locale #713
PR Add plugin typings from DefinitelyTyped #657: Add plugin typings from DefinitelyTyped
address iOS/macOS resource leak when deleting database without closing first
Use extra durable build option as described in EXTRA DURABLE build setting to improve robustness against corruption #736 (comment)
review any other possible causes of database corruption
ref: EXTRA DURABLE build setting to improve robustness against corruption #736TBDiOS/macOS platform version openDatabase checks from https://github.com/brodybits/cordova-sqlite-evmax-legacy-exp-free
Resolve issue with PSPDFKit ref: Duplicated symbols [iOS platform version] cordova-sqlcipher-adapter#59
Windows implementation should include an error object when signaling a close error
Resolve INCORRECT error code / INCONSISTENT error messages on Windows
TBD include actual error code, perhaps in error message (already done on builtin android.database implementation in case of androidDatabaseImplementation: 2 on Android)
Include info about prepare statement error vs execute statement error, as done on Windows
testing with PRAGMA foreign_keys ref: PRAGMA foreign_keys not working cordova-sqlite-evcore-extbuild-free#23
test/document issue with Unicode column name ref: Query result contains wrong key when column name is CJK character #641.
improve testing & documentation related to Unicode characters on Android ref: Unicode issues (Android) #739
document existence of spatialite fork
pointer to https://github.com/Crypho/cordova-plugin-secure-storage
ADDITIONAL DOCUMENTATION:
MAJOR DOCUMENTATION CLEANUP NEEDED here or in NEXT MAJOR RELEASE (#687) ref: storesafe/cordova-sqlite-storage-help#33 & #596 (comment)
Timeline
4-6 weeks due to existing backlogThe text was updated successfully, but these errors were encountered: