Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: improve spinner to not hide text and be more CI-friendly #105

Merged
merged 1 commit into from
Jun 19, 2023
Merged

fix: improve spinner to not hide text and be more CI-friendly #105

merged 1 commit into from
Jun 19, 2023

Conversation

DenKoren
Copy link
Contributor

  • don't hide 'Getting ...' info message when spinner is shown.
  • don't show spinner at all when output is not a TTY

@DenKoren
fix: improve spinner to not hide text and be more CI friendly
cebf8ff 
- don't hide 'Getting ...' info message when spinner is shown.
- don't show spinner at all when output is not a TTY
@stormcat24 stormcat24 self-requested a review June 19, 2023 04:27
stormcat24
stormcat24 approved these changes Jun 19, 2023
View reviewed changes
Copy link
Owner

@stormcat24 stormcat24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DenKoren Nice catch 👍

@stormcat24 stormcat24 merged commit 18d8ca5 into stormcat24:master Jun 19, 2023
@stormcat24
Copy link
Owner

@DenKoren
I released this improvement as v0.1.8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stormcat24 stormcat24 stormcat24 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DenKoren @stormcat24