Build against numpy 2.0rc1 #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cibuildwheel doesn't seem to show enough verbosity to know that it is using numpy 2 for building the wheel (it uses 1.26 for testing the wheel and passes). But since the pyproject.toml specifies it I think it is safe. |
|
As far as I can tell this works. I created a local environment with numpy 2.0.0rc1 and the wheels created by this PR and I can import it. If I install pyresample locally against numpy 2.0.0rc1 and try to import it it fails to import pandas with: If you're OK with this @mraspaud then I think this is ready for merge and release. |
….Inf alias was removed)
|
FYI @neutrinoceros I moved your Inf commit here, but didn't include the pyproject.toml ones as I like my version better 😉 |
|
Got approval from Martin on slack... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.