Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(common): fix dependabot error #274

Merged
merged 3 commits into from
Sep 21, 2023
Merged

Conversation

eunjae-lee
Copy link
Contributor

What?

We have configured dependabot but it's not working.

https://github.com/storyblok/field-plugin/network/updates/722059282

In the end of the log I've found something suspicious:

updater | +-----------------------------------+
updater | |   Dependencies failed to update   |
updater | +-------------------+---------------+
updater | | eslint-plugin-vue | unknown_error |
updater | +-------------------+---------------+

Not sure what's going on, but let's exclude eslint-plugin-vue from our dependabot config, and see what happens.

How to test? (optional)

@vercel
Copy link

vercel bot commented Sep 19, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
plugin-sandbox ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 21, 2023 8:56am

@eunjae-lee eunjae-lee requested review from a team and demetriusfeijoo and removed request for a team September 19, 2023 09:56
Copy link
Contributor

@demetriusfeijoo demetriusfeijoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took a quick look in the generated log you've attached @eunjae-lee, and found also this:

(Dependabot::SharedHelpers::HelperSubprocessFailed)
updater | 2023/09/14 17:50:41 ERROR <job_722059282> ➤ YN0000: ┌ Resolution step
updater | ➤ YN0002: │ @mui/private-theming@npm:5.14.9 [216e0] doesn't provide react-dom (pe2e13), requested by @mui/utils
updater | ➤ YN0002: │ @mui/system@npm:5.14.9 [9c99a] doesn't provide react-dom (p55794), requested by @mui/utils
updater | ➤ YN0060: │ container@workspace:packages/container provides vite (p90972) with version 3.2.7, which doesn't satisfy what @vitejs/plugin-react requests
updater | ➤ YN0060: │ demo@workspace:packages/demo provides vite (p32ca9) with version 3.2.7, which doesn't satisfy what @vitejs/plugin-react requests
updater | ➤ YN0002: │ field-plugin-monorepo-template@workspace:packages/cli/templates/monorepo doesn't provide eslint-plugin-vue (p0b3eb), requested by @vue/eslint-config-typescript

In the last line

field-plugin-monorepo-template@workspace:packages/cli/templates/monorepo doesn't provide eslint-plugin-vue (p0b3eb), requested by @vue/eslint-config-typescript

It seems the monorepo doesn't include this library in its dependencies, and probably it shouldn't since this template doesn't use Vue.

image

May this is the root cause?

I think we can proceed ignoring the'eslint-plugin-vue' library just to check if it'd be only this, but also we could remove these others dependencies inside the monorepo template and check it again, what do you think Eunjae?

Anyways, I'm approving these one since we can easily revert it after the tests.

@eunjae-lee
Copy link
Contributor Author

@demetriusfeijoo thanks, good catch! I've removed the vue related dependencies. Let's see what happens after merging this :)

@eunjae-lee eunjae-lee enabled auto-merge (squash) September 21, 2023 08:55
@eunjae-lee eunjae-lee merged commit 139d95f into main Sep 21, 2023
11 checks passed
@eunjae-lee eunjae-lee deleted the chore/fix-dependabot-error branch September 21, 2023 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants