feat(lib): add interfaceLang and releases to FieldPluginData
#345
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| @@ -8,10 +8,24 @@ export type FieldPluginData<Content> = { | |||
| content: Content | |||
| options: Record<string, string> | |||
| spaceId: number | undefined | |||
| interfaceLang: string | |||
There was a problem hiding this comment.
Since we have storyLang, I named it interfaceLang, but any other suggestion is welcome.
There was a problem hiding this comment.
interfaceLang is not bad, IMO.
I also though about storyfrontLang, though. 🤔
There was a problem hiding this comment.
storyfront is our project name for the frontend, and it's not publicly used. So I picked interface 🤔
eunjae-lee
requested review from
a team and
demetriusfeijoo
and removed request for
a team
There was a problem hiding this comment.
Hey @eunjae-lee, as per the discussion on the open ticket, I think we'll need to also accept a releaseId, right?
Or just the releases: [] would be enough? wdyt?
| @@ -8,10 +8,24 @@ export type FieldPluginData<Content> = { | |||
| content: Content | |||
| options: Record<string, string> | |||
| spaceId: number | undefined | |||
| interfaceLang: string | |||
There was a problem hiding this comment.
interfaceLang is not bad, IMO.
I also though about storyfrontLang, though. 🤔
…-plugin-sdk-to-include-the-releases-data
yeah, I tested it, and storyfront doesn't always provide releaseId (I don't understand the logic yet). It's sometimes undefined. So I thought I could expose releases only, and see if people really need releaseId :) |
…-plugin-sdk-to-include-the-releases-data
…-plugin-sdk-to-include-the-releases-data
Yeah, I don't have experience on that side either, so I don't know how it behaves 😞 but we may use the open ticket to ask the user if this would be enough, wdyt? I mean, It can happen that the user doesn't need this in the end but as it was explicitly requested, it may be better to check with him/her before. What do you think? |
|
If you're in a release, and click a story that belongs to the release, you'll get
|
…-plugin-sdk-to-include-the-releases-data
…-plugin-sdk-to-include-the-releases-data
eunjae-lee
deleted the
EXT-2151-update-the-type-definition-of-field-plugin-sdk-to-include-the-releases-data
branch
What?
This PR adds
interfaceLangandreleasestoFieldPluginData.resolves #344
Why?
JIRA:
How to test? (optional)
storyblok.com needs to be updated first in order for us to get this data in the library.