fix(helper): clean up side effects in Vue 3 helper #423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
johannes-lindgren
changed the title
BibiSebi
approved these changes
Oct 14, 2024
demetriusfeijoo
approved these changes
Oct 14, 2024
|
@johannes-lindgren do we need QA? if not, you can merge it! |
|
@gustavomelki not in this repository, I think |
johannes-lindgren
deleted the
SHAPE-7195-effects-are-not-cleaned-up-in-storyblok-field-plugin-vue-3_2
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the vue3 helper, side effects from
createFieldPluginare not being cleaned up.If the application is never remounted, this is normally not a problem.
How to test? (optional)
The Vue3 template should work as before.