Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make types compatible with TypeScript strict mode #74

Merged
merged 1 commit into from
Jan 17, 2023
Merged

Make types compatible with TypeScript strict mode #74

merged 1 commit into from
Jan 17, 2023

Conversation

RSWilli
Copy link
Contributor

@RSWilli RSWilli commented Oct 18, 2022

see #73

changed the events type parameter to any for Template and Story, since those are the default, as per this line

@RSWilli RSWilli mentioned this pull request Dec 7, 2022
Closed
kasperpeulen
kasperpeulen approved these changes Jan 16, 2023
View reviewed changes
Copy link

@kasperpeulen kasperpeulen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JReinhold JReinhold added patch Increment the patch version when merged bug Something isn't working labels Jan 17, 2023
@JReinhold JReinhold changed the title change typescript types to work with strict types Make types compatible with TypeScript strict mode Jan 17, 2023
@JReinhold JReinhold merged commit af732df into storybookjs:main Jan 17, 2023
@shilman
Copy link
Member

shilman commented Jan 17, 2023

🚀 PR was released in v2.0.11 🚀

@shilman shilman added the released This issue/pull request has been released. label Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kasperpeulen kasperpeulen kasperpeulen approved these changes

Assignees

@kasperpeulen kasperpeulen

@JReinhold JReinhold

Labels
bug Something isn't working patch Increment the patch version when merged released This issue/pull request has been released.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RSWilli @shilman @kasperpeulen @JReinhold