Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use react-docgen@6.0.0-alpha.0 #104

Closed

Conversation

joshwooding
Copy link
Member

react-docgen@6.0.0-alpha.0 is out and allows resolving of imported types/proptypes and has no breaking changes (https://github.com/reactjs/react-docgen/releases/tag/v6.0.0-alpha.0). We want to explore this in storybookjs/builder-vite#167 any chance of releasing this dependency bump as an alpha to test the waters?

@mscott2757
Copy link

I think there may be additional work to get this to work, by default this new behavior is not enabled to be backwards compatible

we need to pass makeFsImporter to the parse method from what I understand

From the original PR

Made the "importer" configurable. It is passed as an argument to the parse method, but if using the defaultParse from main.js, it is an additional option that can be specified. This is to make everything backwards compatible.

@silawrenc
Copy link

@mscott2757 I've got a fork of this working here, would you be open to a PR back here with a similar implementation? Were you thinking that there would also need to be an option for the plugin to enable/disable the importer? or provide a different importer altogether?

@rp4rk
Copy link

rp4rk commented Apr 11, 2022

Hi folks, just bumping this PR because we're maintaining a fork of the changes it makes over here. Are there any other changes to be considered at all other than the ones discussed so far?

@mayank99
Copy link

I noticed that react-docgen is being actively developed again. The -alpha.0 was released over a year ago, but last month there were newer releases (with breaking changes).

Sounds like a good time to consider supporting 6.0 in storybook core.

@ndelangen ndelangen added the dependencies Update one or more dependencies version label Jan 16, 2023
@stianjensen
Copy link

And now 6.0 is out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Update one or more dependencies version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants