Test built storybooks in CI #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The svelte stories are not being picked up correctly by the test runner. I've opened storybookjs/test-runner#80. |
IanVS
force-pushed
the
storybook-test-ci
branch
from
2f3e1a4
to
e163a02
Compare
|
I had to remove the svelte example, unfortunately. It seems that @storybook/test-runner does not support svelte component stories. |
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far, we've only been building our storybooks, but not doing any testing on them. This adds https://github.com/storybookjs/test-runner which will render each of the stories and smoke test them (make sure that there are no runtime errors). This is at least a step towards having more confidence that our stories aren't broken. The next step would be to actually write assertions in the stories to be sure they're rendering correctly, but that can be done another time.