Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pluginutils from dependencies #470

Merged
merged 1 commit into from
Aug 8, 2022

Conversation

kazuma1989
Copy link
Contributor

@kazuma1989 kazuma1989 commented Aug 1, 2022

Hi. A small fix here 👍

I've removed @rollup/pluginutils from the dependencies list because createFilter util is exposed from Vite v3. (vite >= 3 is in the peer deps, so it's safe)
Less dependencies are better.

because `createFilter` util is exposed from Vite v3.
vitejs/vite#8562
Copy link
Member

@IanVS IanVS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, this is one reason I'm not a huge fan of vite bundling all of their dependencies. If they didn't do that, package managers could de-duplicate the @rollup/pluginutils that vite uses and the @rollup/pluginutils in the dependencies here, and there'd be no impact to the size of node_modules by us depending on it directly. Instead, vite is stuck with having to re-export things and relying on other packages like this one to use what vite provides instead of using the dependencies directly.

That said, it's a decision they've made, and now to avoid extra dependencies we do need this PR. Thanks for submitting it.

@IanVS IanVS merged commit a824bef into storybookjs:main Aug 8, 2022
@kazuma1989 kazuma1989 deleted the remove-pluginutils branch August 9, 2022 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants