Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect use of styled #174

Closed
tmeasday opened this issue Jul 15, 2020 · 2 comments · Fixed by #176
Closed

Incorrect use of styled #174

tmeasday opened this issue Jul 15, 2020 · 2 comments · Fixed by #176
Assignees
Labels
bug Something isn't working released

Comments

@tmeasday
Copy link
Member

This commit: 6bed387

Introduces a memory leak as you are definitely not supposed to use styled inline inside a component. What that does is create a leak where a new style definition is created every time you render the component.

@tmeasday tmeasday added the bug Something isn't working label Jul 15, 2020
@tmeasday
Copy link
Member Author

Here's a snippet of the HTML that is rendered by a simple page by my NextJS development server:

image

Those styles are the linkStyles referred to in this file.

@kylesuss
Copy link
Collaborator

🚀 Issue was released in v5.1.2 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants