Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not dynamically generate styled link component in render #176

Merged
merged 2 commits into from
Jul 23, 2020
Merged

Do not dynamically generate styled link component in render #176

merged 2 commits into from
Jul 23, 2020

Conversation

kylesuss
Copy link
Collaborator

The solution to this needs to:

  1. Allow a link to have a LinkWrapper
  2. Allow a link to be a button (that looks like a link)
  3. Not pass down arbitrary props to an a element (like nochrome or inverse) as that throws console warnings
  4. Not dynamically generate styled components during render

Think I have all 4 covered!

Closes #174

@kylesuss kylesuss requested review from domyen and tmeasday July 21, 2020 22:21
tmeasday
tmeasday approved these changes Jul 22, 2020
View reviewed changes
Copy link
Member

@tmeasday tmeasday left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- one thing though: this assumes a LinkWrapper generates an <a> right? Is that something we've always guaranteed?

@kylesuss
Copy link
Collaborator Author

@tmeasday

LGTM -- one thing though: this assumes a LinkWrapper generates an right? Is that something we've always guaranteed?

No I don't think we have guaranteed that, but I am struggling to think of a time where that wouldn't be true. What use case are you thinking of?

@tmeasday
Copy link
Member

No I don't think we have guaranteed that, but I am struggling to think of a time where that wouldn't be true. What use case are you thinking of?

No idea, I was just checking! If you think it is good, let's release this!

@kylesuss kylesuss merged commit fc34125 into master Jul 23, 2020
@kylesuss kylesuss deleted the fix-massive-styles branch July 23, 2020 19:10
@kylesuss
Copy link
Collaborator Author

🚀 PR was released in v5.1.2 🚀

@kylesuss kylesuss mentioned this pull request Jul 23, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domyen domyen domyen approved these changes

@tmeasday tmeasday tmeasday approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect use of styled
3 participants
@kylesuss @tmeasday @domyen