fix: Avatar accessibility #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! This is awesome 🙇 |
|
🚀 PR was released in v0.0.23 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the problem this PR is trying to solve?
Avatar component is not accessible
(SR = Screen Reader)
The loading avatar is just skipped by SR (yeah I added a "lol" text on the left to show that the focus switch between the elements between the loading avatar, it's kind of my default text when I don't know what to write :D )
A loader should have aria-busy attribute and a text alternative if it doesn't contains explicit text.
The initial avatar alt attribute is not taken into account by SR, it reads only the initial letter
What is the chosen solution to this problem?
Set the aria-busy attribute and a
Loading avatar ...aria-labelHide the initial with aria-hidden, and set the username in an aria-label instead of alt attribute