Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove package-lock.json #153

Merged
merged 2 commits into from
Feb 5, 2020
Merged

Remove package-lock.json #153

merged 2 commits into from
Feb 5, 2020

Conversation

shilman
Copy link
Member

@shilman shilman commented Feb 5, 2020 •
edited
Loading

Introduced here: 8433ab3

We shouldn't have two lockfiles in the repo

@shilman shilman requested a review from kylesuss February 5, 2020 03:55
@shilman shilman added the internal Changes only affect the internal API label Feb 5, 2020
kylesuss
kylesuss approved these changes Feb 5, 2020
View reviewed changes
Copy link
Collaborator

@kylesuss kylesuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch 💯

@kylesuss kylesuss merged commit b6ac2fd into master Feb 5, 2020
@kylesuss kylesuss deleted the remove-package-lock branch February 5, 2020 17:10
@ghengeveld
Copy link
Member

🚀 PR was released in v4.0.0 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kylesuss kylesuss kylesuss approved these changes

Assignees
No one assigned
Labels
internal Changes only affect the internal API released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shilman @ghengeveld @kylesuss