Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: AvatarList ellipsis in an li #16

Merged
merged 1 commit into from
Jun 15, 2019
Merged

Conversation

jsomsanith-tlnd
Copy link
Contributor

What is the problem this PR is trying to solve?
#14 fixed the AvatarList semantic with ul/li. But the ellipsis is still in a div.

What is the chosen solution to this problem?
Use li for the ellipsis instead.

@domyen domyen merged commit 16690c1 into master Jun 15, 2019
@jsomsanith-tlnd jsomsanith-tlnd deleted the jsomsanith/fix/avatar_list_ul_li branch June 16, 2019 20:12
@kylesuss
Copy link
Collaborator

🚀 PR was released in v0.0.23 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants