Remove keycode, reduce bundle size #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
force-pushed
the
remove-keycode
branch
from
bd8efff
to
2fa0224
Compare
|
I'm looking into how we can increase the usage of the Material-UI components in the OSS community, while the unstyled and style engine interop stories we have for v5 is meant to greatly help, we might not get it stable before early 2021. For now, I'm looking at existing opportunities that can benefit everybody as well as learning more about the use cases. If you are interested, I have noticed that we can win 1.6 kb with a change of the Modal: 6.5 kB -> 4.9 kB.
|
|
Thanks @oliviertassinari will take a deeper look in the next couple of days. Appreciate the link to the MUI issue 🙏 |
kylesuss
approved these changes
Apr 7, 2020
There was a problem hiding this comment.
Nice one, thanks @oliviertassinari . Just pulled it down to try it out. Easy win!
|
🚀 PR was released in v5.1.0 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A simple win I noticed looking at the source of the design system. You can learn more about how it can work in mui/material-ui#14248 (it only works with synthetic events).