-
Notifications
You must be signed in to change notification settings - Fork 585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TagItem and TagList components #212
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm good on this, pending any API comments from others 👍
@winkerVSbecks nice, sounds and looks good to me. Out of curiosity, Varun, do you think all components in this design system should export themselves as a |
Yea, that seems to be the pattern most DS adopt. Makes sense since they are mostly low level components. That said, typing those components is a pain. I don't plan on rewriting everything. We can do that for new components and update old components as and when necessary. |
@winkerVSbecks just checked the latest commit you've made and it looks really great. I'm good with it as well 👍 |
Heads up, I'm leaving specific UI comments in Chromatic |
@domyen updated with changes you requested. |
🚀 PR was released in |
Not sure if this is the best API for the
TagList