Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove extra space around the github button #213

Merged
merged 1 commit into from
Oct 19, 2020
Merged

remove extra space around the github button #213

merged 1 commit into from
Oct 19, 2020

Conversation

winkerVSbecks
Copy link
Collaborator

No description provided.

@winkerVSbecks winkerVSbecks added the bug Something isn't working label Oct 16, 2020
kylesuss
kylesuss approved these changes Oct 19, 2020
View reviewed changes
Copy link
Collaborator

@kylesuss kylesuss left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 we ignore the GitHubButton in the DOM right (for Chromatic)? Think so, but LGTM.

@winkerVSbecks
Copy link
Collaborator Author

Good point, I should ignore it too otherwise it'll cause unnecessary failures.

@winkerVSbecks winkerVSbecks merged commit 0e6793f into master Oct 19, 2020
@winkerVSbecks winkerVSbecks deleted the github-button-spacing branch October 19, 2020 15:41
@kylesuss
Copy link
Collaborator

🚀 PR was released in v5.2.0 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kylesuss kylesuss kylesuss approved these changes

@domyen domyen Awaiting requested review from domyen

Assignees
No one assigned
Labels
bug Something isn't working released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@winkerVSbecks @kylesuss