Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the problem this PR is trying to solve?
Select component is not accessible
What is the chosen solution to this problem?
for
attribute. We introduce thehideLabel
props. Be careful to give a clear context when you hide the label in the designsaria-describedby
aria-invalid
on select when there is an erroraria-hidden
to the iconLoading
label, that is associated with the select as a descriptionn, so screen reader will read it on focus. The select has anaria-busy
attribute too