Refactor Highlight CSS loading to avoid css-loader expectation #29
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An interesting thing happened when I was trying to import this design system into another app -- the CSS file in the
Highlight
component was throwing errors as if it could not be loaded properly. I've realized that there is not an issue w/ this in Storybook as they have their own CSS loader and so does Gatsby (which is why it didn't come up during the learnstorybook.com development).Therefore, I have decided to just copy over the prism CSS theme rather than try to import the CSS file for a few reasons:
css-loader
css-loader
that I could use instead (we build the design system w/ babel and not webpack)css-loader