Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update outline button appearance shadow to secondary color #31

Merged
merged 1 commit into from
Jun 26, 2019

Conversation

kylesuss
Copy link
Collaborator

Self explanatory. The outline button had a red focus shadow. I suspect this is because the primary color of the design system is different than the primary color of where this button was originally implemented.

Easy fix!

box-shadow: ${color.medium} 0 0 0 1px inset, ${rgba(
color.secondary,
0.2
)} 0 8px 18px 0px;
Copy link
Collaborator Author

@kylesuss kylesuss Jun 26, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Prettier?

¯\_(ツ)_/¯

@kylesuss kylesuss requested a review from domyen June 26, 2019 15:33
@domyen domyen merged commit 7638cf7 into master Jun 26, 2019
@domyen domyen deleted the fix-outline-shadow branch June 26, 2019 15:37
@kylesuss
Copy link
Collaborator Author

🚀 PR was released in v0.0.27 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants