Pulled in AddonItem component from frontpage
#320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 17, 2021 15:42
- added verified badge stories - pulled in addonitem => displaycard - added displaycard stories - pulled in an addon illustration - added new illustration story
domyen
reviewed
Nov 18, 2021
- update images based on Dom's feedback - use startOpen in verified badge story
domyen
approved these changes
Nov 22, 2021
|
🚀 PR was released in |
domyen
deleted the
amber/ch-734-pull-addonitem-from-frontpage-into-ds
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://linear.app/chromaui/issue/CH-734/pull-addonitem-from-frontpage-into-ds
Description
Pulled the
AddonItemcomponent from https://github.com/storybookjs/frontpage into the DS in preparation for future work and called itDisplayCardinstead as it will be used for more general purposes.Also pulled in the
VerifiedBadgecomponent from https://github.com/storybookjs/frontpage as it's used in theAddonItem.QA instructions
Confirm the styles (mostly) match [the designs]((https://www.figma.com/file/gYdEmX9zYowUR3K2SOua5J/Component-catalog?node-id=180%3A8141).
📦 Published PR as canary version:
7.0.3-canary.320.c1268bc.0✨ Test out this PR locally via:
npm install @storybook/design-system@7.0.3-canary.320.c1268bc.0 # or yarn add @storybook/design-system@7.0.3-canary.320.c1268bc.0