fix: Link - LinkWrapper optimisation #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylesuss
force-pushed
the
jsomsanith/fix/link_wrapper_optimisation
branch
from
0cac904
to
b16f5df
Compare
kylesuss
approved these changes
Jun 29, 2019
| ${linkStyles}; | ||
| ` | ||
| ); | ||
| }; |
|
🚀 PR was released in v0.0.35 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the problem this PR is trying to solve?
Link component accepts a
LinkWrapperprops. It is styled via styled-component, but it’s not exactlyLinkWrapperthat is passed, but a new component that omits a set of props.But everytime
Linkrenders, the styledLinkWrapperis created again, defining a new component.React considers it as a new component, the old button will be unmounted, and the new one will be mounted, at every render.
What is the chosen solution to this problem?
Memoize the styled
LinkWrappercomponent.Bonus: the weird
Linkstory with a button as child is removed, inn favor ofButtoncomponent withButtonWrapper