Fix hook usage #66
Merged
Fix hook usage #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leerob
approved these changes
Aug 8, 2019
kylesuss
reviewed
Aug 8, 2019
| @@ -164,7 +164,7 @@ export function ListItem({ | |||
| ); | |||
|
|
|||
| if (LinkWrapper) { | |||
| const StyledLinkWrapper = useMemo(() => buildStyledLinkWrapper(LinkWrapper), [LinkWrapper]); | |||
| const StyledLinkWrapper = buildStyledLinkWrapper(LinkWrapper); | |||
There was a problem hiding this comment.
There is another usage similar to this:
design-system/src/components/Button.js
Line 335 in a46acaa
Do you think it needs updating as well?
There was a problem hiding this comment.
I asked on Discord if any consumers are using SSR. It seems like no usage of useMemo is working in a Next.js application. I'm gonna see how it all goes in a CRA environment today.
kylesuss
requested changes
Aug 9, 2019
There was a problem hiding this comment.
For tracking purposes, just posting this review until we can verify that there are no issues w/ Next & CRA
re: #66 (comment)
|
🚀 PR was released in v1.1.0 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.