Skip to content
This repository has been archived by the owner on May 16, 2024. It is now read-only.

Fix version in package.json, support yarn 3 #41

Merged
merged 13 commits into from
Aug 29, 2023
Merged

Fix version in package.json, support yarn 3 #41

merged 13 commits into from
Aug 29, 2023

Conversation

IanVS
Copy link
Member

@IanVS IanVS commented Aug 23, 2023

Change Type

Indicate the type of change your pull request is:

  • maintenance
  • documentation
  • patch
  • minor
  • major

This does a few main things:

  • Fixes the version number in package.json (is it not updated as part of the release process?)
  • Adds support for yarn 3, otherwise a fresh clone and yarn install sets up pnp mode and a lot of extra files.
  • Updates the release CI job to:
    • Use updated actions to avoid deprecation warnings
    • Use yarn 3 + cache
    • Only run once a PR is opened to ensure the release bot can update the PR body with the canary version
📦 Published PR as canary version: 0.2.2--canary.41.6009636227.0

✨ Test out this PR locally via:

npm install @storybook/jest@0.2.2--canary.41.6009636227.0
# or 
yarn add @storybook/jest@0.2.2--canary.41.6009636227.0

@socket-security
Copy link

socket-security bot commented Aug 23, 2023

New dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
@storybook/instrumenter 7.4.0-alpha.2 network +35 9.28 MB shilman

@socket-security
Copy link

socket-security bot commented Aug 23, 2023

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Issue Package Version Note Source
New author nopt 6.0.0
Shell access node-gyp 9.4.0

Next steps

What is new author?

A new npm collaborator published a version of the package for the first time. New collaborators are usually benign additions to a project, but do indicate a change to the security surface area of a package.

Scrutinize new collaborator additions to packages because they now have the ability to publish code into your dependency tree. Packages should avoid frequent or unnecessary additions or changes to publishing rights.

What is shell access?

This module accesses the system shell. Accessing the system shell increases the risk of executing arbitrary code.

Packages should avoid accessing the shell which can reduce portability, and make it easier for malicious shell access to be introduced.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@* or ignore all packages with @SocketSecurity ignore-all

  • @SocketSecurity ignore nopt@6.0.0
  • @SocketSecurity ignore node-gyp@9.4.0

@IanVS IanVS mentioned this pull request Aug 23, 2023
5 tasks
Copy link
Collaborator

@kasperpeulen kasperpeulen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

package.json Outdated Show resolved Hide resolved
@yannbf yannbf merged commit 74120cb into next Aug 29, 2023
1 of 2 checks passed
@yannbf yannbf deleted the cleanup branch August 29, 2023 08:17
@github-actions github-actions bot added the prerelease This change is available in a prerelease. label Aug 29, 2023
@github-actions
Copy link

🚀 PR was released in v0.2.2 🚀

@github-actions github-actions bot added released This issue/pull request has been released. and removed prerelease This change is available in a prerelease. labels Aug 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
released This issue/pull request has been released. skip-release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants