-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to 7.0 / mdx2-csf structure #19
Conversation
Socket Security Pull Request ReportDependency issues detected. If you merge this pull request, you will not be alerted to the instances of these issues again. 📜 Install scriptsInstall scripts are run when the package is installed. The majority of malware in npm is hidden in install scripts. Packages should not be running non-essential scripts during install and there are often solutions to problems people solve with install scripts that can be run at publish time instead.
😵💫 Bin script confusionThis package has multiple bin scripts with the same name. This can cause non-deterministic behavior when installing or could be a sign of a supply chain attack Consider removing one of the conflicting packages. Packages should only export bin scripts with their name
Pull request report summary
Bot CommandsTo ignore an alert, reply with a comment starting with
Powered by socket.dev |
Issue: storybookjs/storybook#20145
What Changed
When
mdx1-csf
was created, it was designed to be interchangeable withmdx2-csf
, which provided experimental MDX2 support in Storybook 6.5.Then, in Storybook 7.0, we evolved
mdx2-csf
in a variety of ways:tsup
'stories-mdx'
tags to compiled storiesThe plan was to abandon
mdx1-csf
, because MDX1 is now legacy. However, due to MDX1 => 2 upgrade pains, we decided to add opt-in transitional MDX1 support for people who are upgrading to SB7 and want a stopgap to view working MDX1 before going through the MDX2 upgrade process. See storybookjs/storybook#20145This PR adopts the latest
mdx2-csf
structure and improvements and applies them tomdx1-csf
. It corresponds to storybookjs/storybook#20747 in the monorepo.How to test
See storybookjs/storybook#20747
Change Type
maintenance
documentation
patch
minor
major
📦 Published PR as canary version:
0.0.5--canary.19.89e7fd1.0
✨ Test out this PR locally via:
npm install @storybook/mdx1-csf@0.0.5--canary.19.89e7fd1.0 # or yarn add @storybook/mdx1-csf@0.0.5--canary.19.89e7fd1.0
Version
Published prerelease version:
v1.0.0-next.0
Changelog
💥 Breaking Change
🐛 Bug Fix
Authors: 2