Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CHORE] Update Storybook 7.5.3 #79

Merged
merged 10 commits into from
Nov 29, 2023
Merged

[CHORE] Update Storybook 7.5.3 #79

merged 10 commits into from
Nov 29, 2023

Conversation

ahna92
Copy link
Contributor

@ahna92 ahna92 commented Nov 6, 2023 •
edited by sumwatshade
Loading

Describe your changes

  • Update typescript 5.2.2
  • Update React 18.2.0
  • Update storybook
  • Update awesome fonts
  • Add iOS 17 OS support
  • Add iOS 15 pro + max
  • Add android 13 OS
  • Add pixel 7
  • Node 18 React 18+ support #78

UI changes

image

Testing

  • example android material ui
  • example ios material ui
  • example flutter
  • example controls
  • example cross platform
📦 Published PR as canary version: 2.2.9-canary.79.843.0

✨ Test out this PR locally via:

npm install @storybook/native-android-material-deep-link-example@2.2.9-canary.79.843.0
npm install @storybook/native-controls-example@2.2.9-canary.79.843.0
npm install @storybook/native-cross-platform-example@2.2.9-canary.79.843.0
npm install @storybook/native-flutter-example@2.2.9-canary.79.843.0
npm install @storybook/native-ios-example-deep-link@2.2.9-canary.79.843.0
npm install @storybook/native-addon@2.2.9-canary.79.843.0
npm install @storybook/native-controllers@2.2.9-canary.79.843.0
npm install @storybook/deep-link-logger@2.2.9-canary.79.843.0
npm install @storybook/native-dev-middleware@2.2.9-canary.79.843.0
npm install @storybook/native-devices@2.2.9-canary.79.843.0
npm install @storybook/native-components@2.2.9-canary.79.843.0
npm install @storybook/native@2.2.9-canary.79.843.0
npm install @storybook/native-types@2.2.9-canary.79.843.0
# or 
yarn add @storybook/native-android-material-deep-link-example@2.2.9-canary.79.843.0
yarn add @storybook/native-controls-example@2.2.9-canary.79.843.0
yarn add @storybook/native-cross-platform-example@2.2.9-canary.79.843.0
yarn add @storybook/native-flutter-example@2.2.9-canary.79.843.0
yarn add @storybook/native-ios-example-deep-link@2.2.9-canary.79.843.0
yarn add @storybook/native-addon@2.2.9-canary.79.843.0
yarn add @storybook/native-controllers@2.2.9-canary.79.843.0
yarn add @storybook/deep-link-logger@2.2.9-canary.79.843.0
yarn add @storybook/native-dev-middleware@2.2.9-canary.79.843.0
yarn add @storybook/native-devices@2.2.9-canary.79.843.0
yarn add @storybook/native-components@2.2.9-canary.79.843.0
yarn add @storybook/native@2.2.9-canary.79.843.0
yarn add @storybook/native-types@2.2.9-canary.79.843.0

@socket-security Socket Security
Copy link

socket-security bot commented Nov 6, 2023 •
edited
Loading

New, updated, and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
@storybook/native-components 2.2.8 None +0 33.3 kB amalik2
@storybook/native 2.2.8 None +0 31.6 kB amalik2
@storybook/native-addon 2.2.8 None +0 33.3 kB amalik2
@storybook/native-dev-middleware 2.2.8 None +0 19.9 kB amalik2
storybook 7.5.3 eval +2406 1.72 GB shilman
@babel/preset-react 7.22.15 None +126 56.5 MB nicolo-ribaudo
@babel/preset-typescript 7.23.2 None +150 58.7 MB nicolo-ribaudo
@storybook/manager-api 7.5.3 eval, network +106 33.5 MB shilman
@babel/preset-env 7.23.2 None +630 76.2 MB nicolo-ribaudo
@storybook/react-webpack5 7.5.3 None +1872 4.21 GB shilman
prettier 2.8.8 filesystem, environment +0 11.2 MB prettier-bot
react-dom 18.2.0 None +6 5.06 MB gnoff
@types/lodash.debounce 4.0.6...4.0.8 None +0/-1 3.2 kB types
@storybook/api 6.2.9...7.5.3 None +162/-186 50.4 MB shilman
@storybook/client-api 6.2.9...7.5.3 network +96/-134 23.7 MB shilman
@storybook/addons 6.2.9...7.5.3 network +280/-315 88.1 MB shilman
@types/express 4.17.11...4.17.20 None +22/-8 8.2 MB types
@storybook/components 6.2.9...7.5.3 eval +500/-435 106 MB shilman
@types/fs-extra 9.0.11...9.0.13 None +4/-2 8.02 MB types
@storybook/theming 6.2.9...7.5.3 None +15/-114 14.6 MB shilman
@storybook/core-events 6.2.9...7.5.3 None +2/-2 116 kB shilman
@storybook/react 6.2.9...7.5.3 None +260/-1024 562 MB shilman
copy-to-clipboard 3.3.1...3.3.3 None +0/-0 15.1 kB sudodoki
@fortawesome/fontawesome-svg-core 1.2.35...6.4.2 None +2/-2 1.78 MB robmadole
@fortawesome/free-solid-svg-icons 5.15.3...6.4.2 None +2/-2 6.47 MB robmadole
express 4.17.1...4.18.2 None +66/-46 2.43 MB dougwilson
@fortawesome/react-fontawesome 0.1.14...0.2.0 None +6/-6 2.4 MB robmadole
@material-ui/core 4.11.4...4.12.4 None +48/-48 29.6 MB eps1lon
@typescript-eslint/eslint-plugin 4.6.0...6.9.1 None +47/-42 49.3 MB jameshenry
@typescript-eslint/parser 4.6.0...6.9.1 None +39/-39 44.8 MB jameshenry
react-redux 7.2.4...7.2.9 None +20/-20 4.66 MB acemarke
@storybook/addon-toolbars 6.2.9...7.5.3 network +216/-222 51.2 MB shilman
sort-package-json 1.50.0...1.57.0 None +16/-15 4.54 MB keithamus
@storybook/storybook-deployer 2.8.7...2.8.16 environment +20/-24 732 kB alisowski
redux 4.1.0...4.2.1 None +4/-4 725 kB acemarke
redux-thunk 2.3.0...2.4.2 None +3/-0 483 kB acemarke
axios 0.21.1...0.21.4 None +2/-2 433 kB jasonsaayman
@storybook/addon-docs 6.2.9...7.5.3 None +500/-1146 532 MB shilman
typescript 3.9.7...5.2.2 None +0/-0 40.6 MB typescript-bot
@storybook/addon-controls 6.2.9...7.5.3 shell +358/-238 498 MB shilman

🚮 Removed packages: @types/lodash@4.14.169

@socket-security Socket Security
Copy link

socket-security bot commented Nov 6, 2023 •
edited
Loading

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Issue Package Version Note Source
Bin script confusion @storybook/cli 7.5.3
  • Bin Script: sb
Shell access @storybook/cli 7.5.3
Bin script confusion storybook 7.5.3
  • Bin Script: sb
New author util 0.10.4
New author browserify-sign 4.2.2
New author assert 2.1.0
New author react-dom 18.2.0
New author react-refresh 0.14.0
New author scheduler 0.23.0
New author supports-hyperlinks 2.3.0
New author @babel/plugin-syntax-import-meta 7.10.4
New author hasown 2.0.0
New author puppeteer-core 2.1.1
Uses eval puppeteer-core 2.1.1
New author source-map 0.7.4
New author html-minifier-terser 6.1.0
New author istanbul-lib-report 3.0.1
New author for-each 0.3.3
New author fb-watchman 2.0.2
New author decamelize-keys 1.1.1
New author cacache 15.3.0
New author ssri 8.0.1
New author defaults 1.0.4

@ahna92
Copy link
Contributor Author

ahna92 commented Nov 6, 2023

Hi @sumwatshade
Can you help me checking what is the issue with release step

@ahna92
Copy link
Contributor Author

ahna92 commented Nov 11, 2023

hi @amalik2
can you help with creating a canary for this build , would like to test it on my projects

@chriskurzeja
Copy link

chriskurzeja commented Nov 20, 2023 •
edited
Loading

We'd love to see these updates get merged as we're having great success with storybook native in our design system. Thanks @ahna92 for raising this.

@amalik2 amalik2 added the major label Nov 20, 2023
@amalik2
Copy link
Contributor

amalik2 commented Nov 20, 2023

Hi @ahna92 @chriskurzeja sorry for the delay, a canary version is available for consumption now (it's listed at the bottom of the PR body).

I'll merge this as a major release if the canary version looks good on your end

@ahna92 ahna92 changed the title [CHORE] Update Storybook 7.5.2 [CHORE] Update Storybook 7.5.3 Nov 26, 2023
@ahna92
Copy link
Contributor Author

ahna92 commented Nov 27, 2023

hi @amalik2
I faced compatibility issues when tried to use 7.5.2 so i upgraded to 7.5.3 , let's see if this will help

But need your help with another canary please ,

issue i faced :

TypeError: Cannot read properties of undefined (reading 'getAddonState')
    at useSharedState (http://localhost:9006/vendors-node_modules_storybook_addon-docs_dist_preview_mjs-node_modules_storybook_addon-essen-6844e3.iframe.bundle.js:1167:39945)
    at useAddonState (http://localhost:9006/vendors-node_modules_storybook_addon-docs_dist_preview_mjs-node_modules_storybook_addon-essen-6844e3.iframe.bundle.js:1167:42176)
    at DeviceDecorator (http://localhost:9006/vendors-node_modules_storybook_addon-docs_dist_preview_mjs-node_modules_storybook_addon-essen-6844e3.iframe.bundle.js:1237:53)
    at hookified (http://localhost:9006/sb-preview/runtime.js:7:18973)
    at http://localhost:9006/sb-preview/runtime.js:41:1451
    at http://localhost:9006/sb-preview/runtime.js:41:1912
    at withOutline (http://localhost:9006/vendors-node_modules_storybook_addon-docs_dist_preview_mjs-node_modules_storybook_addon-essen-6844e3.iframe.bundle.js:976:669)
    at hookified (http://localhost:9006/sb-preview/runtime.js:7:18973)
    at http://localhost:9006/sb-preview/runtime.js:41:1451
    at http://localhost:9006/sb-preview/runtime.js:41:1912
image

@amalik2
Copy link
Contributor

amalik2 commented Nov 27, 2023

@ahna92 Updated, the new version is 2.2.9-canary.79.827.0

@ahna92
Copy link
Contributor Author

ahna92 commented Nov 28, 2023

hi @chriskurzeja
I've tested the migration on one of my storybook projects and it's working (still have another 2 to check)
Can you help testing it too , check the migration steps

The migration steps might need some tuning (use yarn add instead of copy/paste)

@amalik2
issue above resolved, also noticed the argtypes structure was changes so had to update the loadash templates

@chriskurzeja
Copy link

@ahna92 I see you found the issue with deviceDecorator. I hadn't had chance to dig into it so nice one for spotting it.

@chriskurzeja
Copy link

@ahna92 @amalik2 I've tested 2.2.9-canary.79.829.0 with our design system and it works - the issue we'd had was related to the deviceDecorator but that's now patched. This is great!

amalik2
amalik2 requested changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@amalik2 amalik2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but one comment on the migration guide

MIGRATION.md Outdated
@@ -1,5 +1,90 @@
# Migration Guide

## Version `6.*` to Version `7.*`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you change this to Version 2 to Version 3 so that its consistent with the existing migration guide?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@amalik2 amalik2 merged commit 528b5b1 into storybookjs:master Nov 29, 2023
6 of 7 checks passed
@sumwatshade
Copy link
Contributor

🚀 PR was released in v3.0.0 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amalik2 amalik2 amalik2 approved these changes

Assignees
No one assigned
Labels
major released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ahna92 @chriskurzeja @amalik2 @sumwatshade @edna-aa