Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pnp continue #18

Closed
wants to merge 21 commits into from
Closed

Pnp continue #18

wants to merge 21 commits into from

Conversation

igor-dv
Copy link
Member

@igor-dv igor-dv commented Jun 22, 2019 •
edited
Loading

Based on #8

@igor-dv igor-dv self-assigned this Jun 22, 2019
@igor-dv
Copy link
Member Author

igor-dv commented Jun 22, 2019

@ndelangen @shilman ☝️ it's ready.

We will need to release preset-typescript as well.

@drphelps
Copy link

@ndelangen @shilman @igor-dv What is the status of this PR please?

@ndelangen
Copy link
Member

@igor-dv do you plan on finishing this? @drphelps would you be able to help maybe?

@gaetanmaisse gaetanmaisse mentioned this pull request Jan 25, 2020
Closed
@gaetanmaisse
Copy link
Member

This PR is maybe not useful anymore as we are working on supporting Yarn 2 (and so PnP) in SB directly?

@gaetanmaisse
Copy link
Member

Closing as PnP support has been handled in other PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndelangen ndelangen ndelangen left review comments

@shilman shilman shilman left review comments

Assignees

@igor-dv igor-dv

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@igor-dv @drphelps @ndelangen @gaetanmaisse @shilman @crubier