Skip to content

Commit

Permalink
remove type and reference for --static-dir flag
Browse files Browse the repository at this point in the history
  • Loading branch information
yannbf committed Jan 4, 2024
1 parent 0aa50e9 commit 5e7c185
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 7 deletions.
3 changes: 2 additions & 1 deletion code/lib/core-events/src/errors/server-errors.ts
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,8 @@ export class CouldNotEvaluateFrameworkError extends StorybookError {
}
}

// this error is not used anymore, but we keep it to maintain unique its error code
// which is used for telemetry
export class ConflictingStaticDirConfigError extends StorybookError {
readonly category = Category.CORE_SERVER;

Expand All @@ -138,7 +140,6 @@ export class ConflictingStaticDirConfigError extends StorybookError {
`;
}
}

export class InvalidStoriesEntryError extends StorybookError {
readonly category = Category.CORE_COMMON;

Expand Down
2 changes: 1 addition & 1 deletion code/lib/core-server/src/presets/common-preset.ts
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ export const staticDirs: PresetPropertyFn<'staticDirs'> = async (values = []) =>

export const favicon = async (
value: string | undefined,
options: Pick<Options, 'presets' | 'configDir' | 'staticDir'>
options: Pick<Options, 'presets' | 'configDir'>
) => {
if (value) {
return value;
Expand Down
2 changes: 1 addition & 1 deletion code/lib/core-server/src/utils/server-statics.ts
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ export const parseStaticDir = async (arg: string) => {
throw new Error(
dedent(chalk`
Failed to load static files, no such directory: {cyan ${staticPath}}
Make sure this directory exists, or omit the {bold -s (--static-dir)} option.
Make sure this directory exists.
`)
);
}
Expand Down
4 changes: 0 additions & 4 deletions code/lib/types/src/modules/core-common.ts
Original file line number Diff line number Diff line change
Expand Up @@ -172,10 +172,6 @@ export interface CLIOptions {
host?: string;
initialPath?: string;
exactPort?: boolean;
/**
* @deprecated Use 'staticDirs' Storybook Configuration option instead
*/
staticDir?: string[];
configDir?: string;
https?: boolean;
sslCa?: string[];
Expand Down

0 comments on commit 5e7c185

Please sign in to comment.