Skip to content

Commit

Permalink
converting Shortcuts to a React.Component to resolve issue with React…
Browse files Browse the repository at this point in the history
… Fiber (#1539)
  • Loading branch information
oriSomething committed Aug 2, 2017
1 parent 66a96f5 commit 72e2ba5
Showing 1 changed file with 20 additions and 15 deletions.
35 changes: 20 additions & 15 deletions lib/ui/src/modules/ui/components/shortcuts_help.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import PropTypes from 'prop-types';
import React from 'react';
import React, { Component } from 'react';
import ReactModal from 'react-modal';

const commandStyle = {
Expand Down Expand Up @@ -93,21 +93,26 @@ Keys.propTypes = {
shortcutKeys: PropTypes.arrayOf(PropTypes.string).isRequired,
};

export const Shortcuts = ({ appShortcuts }) => {
const shortcuts = appShortcuts.map(shortcut =>
<div key={shortcut.name}>
<Keys shortcutKeys={shortcut.keys} />
{shortcut.name}
</div>
);
// eslint-disable-next-line react/prefer-stateless-function
export class Shortcuts extends Component {
render() {
const { appShortcuts } = this.props;

return (
<div>
<h4 style={h4Style}>Keyboard Shortcuts</h4>
{shortcuts}
</div>
);
};
const shortcuts = appShortcuts.map(shortcut =>
<div key={shortcut.name}>
<Keys shortcutKeys={shortcut.keys} />
{shortcut.name}
</div>
);

return (
<div>
<h4 style={h4Style}>Keyboard Shortcuts</h4>
{shortcuts}
</div>
);
}
}

Shortcuts.propTypes = {
appShortcuts: PropTypes.arrayOf(
Expand Down

0 comments on commit 72e2ba5

Please sign in to comment.