Merge pull request #4530 from storybooks/tech/smarter-update-check

ADD timeout to update check

lib/core/src/server/build-dev.js

@@ -77,15 +77,19 @@ function applyStatic(app, options) {
   }
 }
 
-const updateCheck = async () => {
+const updateCheck = async version => {
   let result;
   const time = Date.now();
   try {
     const fromCache = await cache.get('lastUpdateCheck', { success: false, time: 0 });
 
     // if last check was more then 24h ago
     if (time - 86400000 > fromCache.time) {
-      const fromFetch = await fetch('https://storybooks.netlify.com/versions.json');
+      const fromFetch = await Promise.race([
+        fetch(`https://storybook.js.org/versions.json?current=${version}`),
+        // if fetch is too slow, we won't wait for it
+        new Promise((res, rej) => global.setTimeout(rej, 1500)),
+      ]);
       const data = await fromFetch.json();
       result = { success: true, data, time };
       await cache.set('lastUpdateCheck', result);
@@ -140,7 +144,11 @@ export async function buildDevStandalone(options) {
 
     const serverListening = listenToServer(server, listenAddr);
 
-    const [stats, updateInfo] = await Promise.all([webpackValid, updateCheck(), serverListening]);
+    const [stats, updateInfo] = await Promise.all([
+      webpackValid,
+      updateCheck(options.packageJson.version),
+      serverListening,
+    ]);
     const proto = options.https ? 'https' : 'http';
     const address = `${proto}://${options.host || 'localhost'}:${port}/`;
     const networkAddress = `${proto}://${ip.address()}:${port}/`;
@@ -189,8 +197,8 @@ export async function buildDevStandalone(options) {
     });
 
     serveMessage.push(
-      ['Local', chalk.cyan(address)],
-      ['On your network', chalk.cyan(networkAddress)]
+      ['Local:', chalk.cyan(address)],
+      ['On your network:', chalk.cyan(networkAddress)]
     );
 
     // eslint-disable-next-line no-console