Merge pull request #20750 from fazulk/update-vue2-template-script-to-…

…use-official-vue2/vite-script Vite: Update sandbox template for vue2 script
storybookjs · Mar 16, 2023 · b86fc2a · b86fc2a
2 parents 558b050 + 2c6c41f
commit b86fc2a
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 12 deletions.
diff --git a/.circleci/config.yml b/.circleci/config.yml
@@ -633,25 +633,25 @@ workflows:
           requires:
             - build
       - create-sandboxes:
-          parallelism: 31
+          parallelism: 30
           requires:
             - build
       # - smoke-test-sandboxes: # disabled for now
       #     requires:
       #       - create-sandboxes
       - build-sandboxes:
-          parallelism: 31
+          parallelism: 30
           requires:
             - create-sandboxes
       - test-runner-sandboxes:
-          parallelism: 31
+          parallelism: 30
           requires:
             - build-sandboxes
       - chromatic-sandboxes:
-          parallelism: 31
+          parallelism: 30
           requires:
             - build-sandboxes
       - e2e-sandboxes:
-          parallelism: 31
+          parallelism: 30
           requires:
             - build-sandboxes
diff --git a/code/lib/cli/src/sandbox-templates.ts b/code/lib/cli/src/sandbox-templates.ts
@@ -187,11 +187,9 @@ const baseTemplates = {
   },
   'vue2-vite/2.7-js': {
     name: 'Vue2 Vite (vue 2.7 JS)',
-    // TODO: convert this to an `npm create` script, use that instead.
-    // We don't really want to maintain weird custom scripts like this,
-    // preferring community bootstrap scripts / generators instead.
-    script:
-      'yarn create vite . --template vanilla && yarn add --dev @vitejs/plugin-vue2 vue-template-compiler vue@2 && echo "import vue2 from \'@vitejs/plugin-vue2\';\n\nexport default {\n\tplugins: [vue2()]\n};" > vite.config.js',
+    script: 'npx create-vue@2 {{beforeDir}} --default',
+    // TODO: reenable this once sandbox is available
+    inDevelopment: true,
     // Re-enable once https://github.com/storybookjs/storybook/issues/19351 is fixed.
     skipTasks: ['smoke-test'],
     expected: {
@@ -376,9 +374,9 @@ const baseTemplates = {
     name: 'Qwik CLI (Default TS)',
     script: 'yarn create qwik basic {{beforeDir}} --no-install',
     // TODO: The community template does not provide standard stories, which is required for e2e tests.
-    skipTasks: ['e2e-tests'],
-    // TODO: Re-enable once problems are fixed.
     inDevelopment: true,
+    // TODO: Re-enable once problems are fixed.
+    skipTasks: ['e2e-tests'],
     expected: {
       framework: 'storybook-framework-qwik',
       renderer: 'storybook-framework-qwik',