Skip to content

Commit

Permalink
ci: use Node 12 in CI as latest version of Yarn introduced in dae3631
Browse files Browse the repository at this point in the history
…needs Node >=12
  • Loading branch information
gaetanmaisse committed Mar 29, 2021
1 parent 2621733 commit f2e774a
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 28 deletions.
41 changes: 14 additions & 27 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
version: 2.1

executors:
sb_node_10_classic:
sb_node_12_classic:
parameters:
class:
description: The Resource class
Expand All @@ -10,20 +10,7 @@ executors:
default: 'medium'
working_directory: /tmp/storybook
docker:
- image: circleci/node:10
environment:
NODE_OPTIONS: --max_old_space_size=3076
resource_class: <<parameters.class>>
sb_node_10_browsers:
parameters:
class:
description: The Resource class
type: enum
enum: ['small', 'medium', 'large', 'xlarge']
default: 'medium'
working_directory: /tmp/storybook
docker:
- image: circleci/node:10-browsers
- image: circleci/node:12
environment:
NODE_OPTIONS: --max_old_space_size=3076
resource_class: <<parameters.class>>
Expand Down Expand Up @@ -77,7 +64,7 @@ jobs:
build:
executor:
class: large
name: sb_node_10_classic
name: sb_node_12_classic
steps:
- git-shallow-clone/checkout_advanced:
clone_options: '--depth 1 --verbose'
Expand Down Expand Up @@ -106,7 +93,7 @@ jobs:
- app
- lib
chromatic:
executor: sb_node_10_browsers
executor: sb_node_12_browsers
parallelism: 4
steps:
# Keep using default checkout because Chromatic needs some git history to work properly
Expand All @@ -120,7 +107,7 @@ jobs:
packtracker:
executor:
class: medium
name: sb_node_10_browsers
name: sb_node_12_browsers
steps:
- git-shallow-clone/checkout_advanced:
clone_options: '--depth 1 --verbose'
Expand All @@ -134,7 +121,7 @@ jobs:
examples:
executor:
class: medium
name: sb_node_10_browsers
name: sb_node_12_browsers
parallelism: 4
steps:
- git-shallow-clone/checkout_advanced:
Expand All @@ -152,7 +139,7 @@ jobs:
publish:
executor:
class: medium
name: sb_node_10_classic
name: sb_node_12_classic
steps:
- git-shallow-clone/checkout_advanced:
clone_options: '--depth 1 --verbose'
Expand All @@ -168,7 +155,7 @@ jobs:
e2e-tests-node-10:
executor:
class: medium
name: sb_node_10_browsers
name: sb_node_12_browsers
working_directory: /tmp/storybook
parallelism: 4
steps:
Expand Down Expand Up @@ -285,7 +272,7 @@ jobs:
e2e-tests-yarn-2-pnp:
executor:
class: medium
name: sb_node_10_browsers
name: sb_node_12_browsers
working_directory: /tmp/storybook
steps:
- git-shallow-clone/checkout_advanced:
Expand Down Expand Up @@ -341,7 +328,7 @@ jobs:
smoke-tests:
executor:
class: medium
name: sb_node_10_browsers
name: sb_node_12_browsers
environment:
# Disable ESLint when running smoke tests to improve perf + As of CRA 4.0.3, CRA kitchen sinks are throwing
# because of some ESLint warnings, related to: https://github.com/facebook/create-react-app/pull/10590
Expand Down Expand Up @@ -412,7 +399,7 @@ jobs:
cd examples/cra-react15
yarn storybook --smoke-test --quiet
frontpage:
executor: sb_node_10_browsers
executor: sb_node_12_browsers
steps:
- git-shallow-clone/checkout_advanced:
clone_options: '--depth 1 --verbose'
Expand All @@ -425,7 +412,7 @@ jobs:
lint:
executor:
class: small
name: sb_node_10_classic
name: sb_node_12_classic
steps:
- git-shallow-clone/checkout_advanced:
clone_options: '--depth 1 --verbose'
Expand All @@ -435,7 +422,7 @@ jobs:
name: Lint
command: yarn lint
unit-tests:
executor: sb_node_10_browsers
executor: sb_node_12_browsers
steps:
- git-shallow-clone/checkout_advanced:
clone_options: '--depth 1 --verbose'
Expand All @@ -451,7 +438,7 @@ jobs:
coverage:
executor:
class: small
name: sb_node_10_browsers
name: sb_node_12_browsers
steps:
- git-shallow-clone/checkout_advanced:
clone_options: '--depth 1 --verbose'
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/tests-unit.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ jobs:
steps:
- uses: actions/setup-node@v1
with:
node-version: '10.x'
node-version: '12.x'
- uses: actions/checkout@v2
- name: Cache node modules
uses: actions/cache@v2
Expand Down

0 comments on commit f2e774a

Please sign in to comment.