Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File search shortcut #121

Closed
ritz078 opened this issue Apr 19, 2016 · 8 comments
Closed

File search shortcut #121

ritz078 opened this issue Apr 19, 2016 · 8 comments

Comments

@ritz078
Copy link
Contributor

ritz078 commented Apr 19, 2016

Instead of having a search box in left, won't it be better to have a search box that pops up on hitting cmd+P with the fuzzy search? I think developers are more used to it.

@arunoda
Copy link
Member

arunoda commented Apr 19, 2016

Yes. That's very cool too. Also, I'll like to have a ctrl + F to render the whole preview in the browser as well.

Related: #59

@ritz078
Copy link
Contributor Author

ritz078 commented Apr 19, 2016

I can work on these.

@arunoda
Copy link
Member

arunoda commented Apr 19, 2016

Ah awesome.
We also discussed a bit on this. We may have to deal with some issues here.

For an example, when we are in focus inside the iframe, our keyboard shortcuts may not work. So, we may need to track short cuts on the iframe as well send them back to the admin page to do the actual effect.

@ritz078
Copy link
Contributor Author

ritz078 commented Apr 19, 2016

As far as the iframe is served from the same domain postMessage can be used.

@arunoda
Copy link
Member

arunoda commented Apr 19, 2016

We don't need to use postMessage, we already have a communication channel.
See: https://github.com/kadirahq/react-storybook/blob/master/src/client/synced_store.js

It's a matter of pushing data to above synced_store.

@ritz078
Copy link
Contributor Author

ritz078 commented Apr 19, 2016

Cool. I will look into that then.

@ritz078
Copy link
Contributor Author

ritz078 commented Apr 22, 2016

Can we finalize on the key bindings for :

  • opening search box (not Cmd+P as it has a default behaviour of Print. Don't want to override expected behaviours)
  • toggling action_logger
  • toggling controls
  • toggle full-screen preview.

@arunoda
Copy link
Member

arunoda commented Apr 22, 2016

@ritz078 I really can't look come up with something straight. Do we need to use (CMD), how about using SHIFT?

@ritz078 ritz078 closed this as completed Apr 26, 2016
ndelangen pushed a commit that referenced this issue Apr 5, 2017
update react-native peer dependency version
ndelangen pushed a commit that referenced this issue Apr 5, 2017
Allow mtrcConf to be set through setDefaults
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants