Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bootstrap command for alpha releases #1433

Closed
2 tasks
shilman opened this issue Jul 8, 2017 · 3 comments
Closed
2 tasks

Fix bootstrap command for alpha releases #1433

shilman opened this issue Jul 8, 2017 · 3 comments
Assignees
Labels
maintenance User-facing maintenance tasks

Comments

@shilman
Copy link
Member

shilman commented Jul 8, 2017

why

npm run bootstrap runs lerna to set up the proper package dependencies for local development. After running it, for example, examples/cra-kitchen-sink should use the freshly built @storybook/* packages on your local machine.

However, when we do alpha releases, our version naming convention differs from semver and lerna uses packages from the npm package server instead. So we need to constantly update the version of packages used in cra-kitchen-sink, partially defeating the value of lerna.

For example, here is the current package.json in the release/3.2 branch:

  "devDependencies": {
    "@storybook/addon-actions": "^3.0.0",
    "@storybook/addon-centered": "^3.0.0",
    "@storybook/addon-events": "^3.0.0",
    "@storybook/addon-knobs": "3.2.0-alpha.7",
    "@storybook/addon-info": "^3.0.0",
    "@storybook/addon-links": "3.2.0-alpha.5",
    "@storybook/addon-notes": "3.2.0-alpha.5",
    "@storybook/addon-options": "3.2.0-alpha.5",
    "@storybook/addon-storyshots": "3.2.0-alpha",
    "@storybook/addons": "^3.0.0",
    "@storybook/react": "3.2.0-alpha.7",
    "react-scripts": "1.0.1"
  },

what

Long-term:

Short-term:

  • be diligent about updating the package.json files in the release/3.2 branch
@jackhurley23
Copy link
Contributor

Lerna have just announced Release 2.0 which may address this issue.
They've improved --canary functionality: lerna/lerna#904

@pksunkara
Copy link
Member

@shilman Are you still encountering this on release/3.4 branch?

@shilman
Copy link
Member Author

shilman commented Sep 21, 2018

Nope, it looks like it's been fixed across the board. Closing this. Yay!

@shilman shilman closed this as completed Sep 21, 2018
@issue-sh issue-sh bot removed the in progress label Sep 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance User-facing maintenance tasks
Projects
None yet
Development

No branches or pull requests

3 participants