Moved to lerna 3 #4067
Merged
Moved to lerna 3 #4067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4067 +/- ##
=======================================
Coverage 40.22% 40.22%
=======================================
Files 467 467
Lines 5638 5638
Branches 748 748
=======================================
Hits 2268 2268
Misses 2994 2994
Partials 376 376Continue to review full report at Codecov.
|
ndelangen
approved these changes
Aug 24, 2018
|
@shilman any objections? |
|
@shilman I will let you merge this since you need to review it |
|
Will this fix #1433 ? |
|
No, I didn't know that was an issue. I know that we don't have to copy licenses anymore after this fix. |
shilman
reviewed
Aug 31, 2018
There was a problem hiding this comment.
Hey @pksunkara ! I tried out this branch publishing to a local NPM registry per @ndelangen 's CLI tests.
I have a few questions before merging.
-
This version apparently doesn't support
--force-publish, which we currently use to publish all the packages at the same version. -
It also doesn't seem to support
--skip-gitwhich makes it harder to test without messing up our git repo -
When I run it against the local registry I see a lot of errors:
MMBP:storybook shilman$ npm run publish:alpha
> @storybook/root@4.0.0-alpha.16 publish:alpha /Users/shilman/projects/storybook/new/storybook
> npm run publish -- --concurrency 1 --force-publish=* --npm-tag=alpha prerelease
> @storybook/root@4.0.0-alpha.16 publish /Users/shilman/projects/storybook/new/storybook
> lerna publish --exact "--concurrency" "1" "--force-publish=*" "--npm-tag=alpha" "prerelease"
lerna notice cli v3.1.4
lerna info current version 4.0.0-alpha.18
lerna ERR! Error: Command failed: git remote update
lerna ERR! fatal: Couldn't find remote ref refs/heads/reproduce-against-master
lerna ERR! error: Could not fetch storybooks
lerna ERR! fatal: Couldn't find remote ref refs/heads/patch-1
lerna ERR! error: Could not fetch joeybaker
lerna ERR! fatal: Couldn't find remote ref refs/heads/patch-1
lerna ERR! error: Could not fetch joscha
lerna ERR! fatal: Couldn't find remote ref refs/heads/haul-support
lerna ERR! error: Could not fetch ericwooley
lerna ERR! fatal: Couldn't find remote ref refs/heads/add-parser-option-getstorybook
lerna ERR! error: Could not fetch AugustinLF
lerna ERR! fatal: Couldn't find remote ref refs/heads/storybook-native-ui
lerna ERR! error: Could not fetch matt-oakes
lerna ERR! fatal: Couldn't find remote ref refs/heads/patch-1
lerna ERR! error: Could not fetch Hypnosphi
lerna ERR! fatal: remote error:
lerna ERR! Repository not found.
lerna ERR! error: Could not fetch mrmartineau
lerna ERR! fatal: Couldn't find remote ref refs/heads/fixes-877
lerna ERR! error: Could not fetch mattleff
lerna ERR!
lerna ERR! Fetching origin
lerna ERR! Fetching ajfuller
lerna ERR! Fetching storybooks
lerna ERR! Fetching joeybaker
lerna ERR! Fetching ranneyd
lerna ERR! Fetching joscha
lerna ERR! Fetching ericwooley
lerna ERR! Fetching AugustinLF
lerna ERR! Fetching igor-dv
lerna ERR! Fetching thomasbertet
lerna ERR! Fetching marcfallows
lerna ERR! Fetching jhurley23
lerna ERR! Fetching matt-oakes
lerna ERR! Fetching ajwhite
...
FYI: I tried upgrading to 3.2.1 and am getting the same errors.
shilman
requested changes
Aug 31, 2018
Weird. I have it working for another repo. Will test this more locally. |
pksunkara
force-pushed
the
pksunkara/lerna
branch
from
ed1bdf7 to
2ccedd6
Compare
Codecov Report
@@ Coverage Diff @@
## master #4067 +/- ##
==========================================
+ Coverage 40.46% 40.52% +0.06%
==========================================
Files 491 467 -24
Lines 5835 5636 -199
Branches 793 747 -46
==========================================
- Hits 2361 2284 -77
+ Misses 3085 2982 -103
+ Partials 389 370 -19
Continue to review full report at Codecov.
|
|
I have updated the PR. And in this comment I will be addressing your review.
It does support it. It's documented here. All
It has been deprecated, but it still works for now. It has been divided into
I am not sure what errors you got. It looks like some git errors and not related to lerna. I will be pasting the logs from my local lerna testing of the publish workflow now on a personal fork of storybook repo. I have upgraded the lerna after taking the recent release. You can see the git log below Running publish:alpha with debug As you can see, Now, I created a commit representing a new change in the package. Now, trying to publish with If I do git log now, you will see that there are no extra commits When I do I am now really convinced that the errors you had were because of something different. |
|
OK let's give this a try! 👍 👍 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.