Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changelogs #1557

Closed
eddiemonge opened this issue Jul 31, 2017 · 2 comments
Closed

Changelogs #1557

eddiemonge opened this issue Jul 31, 2017 · 2 comments
Assignees
Labels
cleanup Minor cleanup style change that won't show up in release changelog

Comments

@eddiemonge
Copy link
Contributor

Since this is now a mono-repo, changelogs are even more criticial to see whats been done in an add-on.

addons-actions is now at version 3.2.0 but the changelog only goes up to 1.x. Please either update the changelog file or remove it. Or better yet, split the add-ons back into separate repos but still under the storybook org

@ndelangen
Copy link
Member

ndelangen commented Jul 31, 2017

Hey @eddiemonge,
There's a changelog in a subproject? Well that'd be legacy content. I guess we could remove it, it's probably no use to anyone anymore..

The monorepo is helping us tremendously in our development, it's not changing. Thanks for the suggestion though, I understand it's not quite the industry standard.
Although projects like babel, webpack, jest also doing it this way, so perhaps it kinda is?

In any case, keep the suggestion coming! We can definitely do with some improvements on the codebase. There's still old examples dev-setups and indeed -as you point out- changelogs laying around from before the monorepo merge.

We want to clean all this up. but at the same time we're careful and want to focus on the things that actually matter. So some things will only get a cleanup if we find the spare time, just feel like cleaning up or it bothers us.

@ndelangen ndelangen added the cleanup Minor cleanup style change that won't show up in release changelog label Aug 2, 2017
@danielduan danielduan self-assigned this Aug 27, 2017
@danielduan
Copy link
Member

I'll get rid of the individual changelogs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Minor cleanup style change that won't show up in release changelog
Projects
None yet
Development

No branches or pull requests

3 participants