Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use better icon for "Reset Controls" button #15734

Closed
jorisw opened this issue Aug 2, 2021 · 8 comments
Closed

Use better icon for "Reset Controls" button #15734

jorisw opened this issue Aug 2, 2021 · 8 comments

Comments

@jorisw
Copy link
Contributor

jorisw commented Aug 2, 2021

Is your feature request related to a problem? Please describe

The Reset button in the top right of Controls, looks like a Refresh button. It made me think it would refresh code, or Controls defaults.
image

Describe the solution you'd like

Better would be to use a 'reset' icon, i.e. something that conveys Undo or Rewind. Example:
image

Are you able to assist to bring the feature to reality?

Assuming you are using an icon set font for this, I'm hoping it will be easy for you to change to an icon that resembles the suggested example.

@shilman
Copy link
Member

shilman commented Aug 2, 2021

Sounds good to me. @MichaelArestad WDYT?

@MichaelArestad
Copy link
Contributor

The closest we have to that is an undo icon in the Design System. It would be a slight improvement over the sync icon.

image

@jorisw
Copy link
Contributor Author

jorisw commented Aug 2, 2021

Agreed!

@awesome31
Copy link
Contributor

Hi! I have not explored the storybook repository and would love to take the first step and take this issue up. Is that okay? 🦖

@shilman shilman added this to the 6.4 improvements milestone Aug 2, 2021
@shilman
Copy link
Member

shilman commented Aug 2, 2021

That would be great @awesome31 -- thank you for helping make Storybook better! 🙏 Please check out how to contribute in our docs and feel free to ask questions in #contributing in our Discord.

@awesome31
Copy link
Contributor

awesome31 commented Aug 2, 2021

Hi! I did create a PR and tested it as per the contribution guidelines. Do check and let me know! Here is the PR: #15737

Also, I am not sure who I should add as a reviewer?

@MichaelArestad
Copy link
Contributor

@awesome31 Thanks! I'm reviewing it now.

@shilman
Copy link
Member

shilman commented Aug 10, 2021

Ooh-la-la!! I just released https://github.com/storybookjs/storybook/releases/tag/v6.4.0-alpha.29 containing PR #15737 that references this issue. Upgrade today to the @next NPM tag to try it out!

npx sb upgrade --prerelease

Closing this issue. Please re-open if you think there's still more to do.

@shilman shilman closed this as completed Aug 10, 2021
niklasmh pushed a commit to niklasmh/storybook that referenced this issue Aug 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants