Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sidebar stories broken on Windows in 6.4-beta #16237

Closed
shilman opened this issue Oct 5, 2021 · 3 comments
Closed

Sidebar stories broken on Windows in 6.4-beta #16237

shilman opened this issue Oct 5, 2021 · 3 comments

Comments

@shilman
Copy link
Member

shilman commented Oct 5, 2021

Have not confirmed this, but appears that something in the new on-demand store is broken on Windows:

image

Repro:

ng new project
cd project
npx sb@next init
@shilman
Copy link
Member Author

shilman commented Oct 18, 2021

@joshwooding
Copy link
Member

joshwooding commented Oct 19, 2021

I believe I have the same issue exposed in a different way. Using 6.4.0-beta.14 with Windows 10 I get the following error on startup:

ERROR in ./storybook-config-entry.js
Module build failed (from ./node_modules/@storybook/builder-webpack4/node_modules/babel-loader/lib/index.js):
SyntaxError: C:\...\storybook-config-entry.js: Bad character escape sequence. (12:45)

  10 | const getProjectAnnotations = () =>
  11 |   composeConfigs([
> 12 |     require('C:\...\node_modules\@storybook\addon-docs\dist\esm\frameworks\common\config.js'),
     |                                              ^
  13 |     require('C:\...\node_modules\@storybook\addon-docs\dist\esm\frameworks\react\config.js'),
  14 |     require('C:\...\node_modules\@storybook\react\dist\esm\client\preview\config.js'),
  15 |     require('C:\...\node_modules\@storybook\addon-links\dist\esm\preset\addDecorator.js'),
    at Object._raise (C:\...\node_modules\@babel\parser\src\parser\error.js:134:45)

I had a go at patching the changes made in windows-debug2 which fixed this error but other things break (I get infinite loading when starting storybook and building storybook statically loads the side panel but can't load any of the stories.

@shilman
Copy link
Member Author

shilman commented Oct 22, 2021

Yowza!! I just released https://github.com/storybookjs/storybook/releases/tag/v6.4.0-beta.19 containing PR #16445 that references this issue. Upgrade today to the @next NPM tag to try it out!

npx sb upgrade --prerelease

Closing this issue. Please re-open if you think there's still more to do.

@shilman shilman closed this as completed Oct 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants