StoryIndex: Detect added/moved directories and batch invalidations #16432
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:#16295
What I did
I use the files glob to scan the directory. This may be a mistake--perhaps I should just scan all files in the directory. What do you think? (this would be a rare event)
INVALIDATE
event, so it fires at most twice, at least if watchpack events fire with no gap larger than 50ms.How to test
src/addon-docs
directory [optionally add some more files in there too].INVALIDATE
event only fired twice andstories.json
was only fetched 4 times (2x2[manager+preview]).Yes we have tests