3.3.4 -> 3.3.5 ENOENT: no such file or directory, stat '.../node_modules/@storybook/react/dist/server/public/index.html #2680
Comments
joscha
changed the title
|
Just checked |
joscha
changed the title
|
@joscha Yikes, that's pretty bad. Have you looked at the change in |
|
@joscha FWIW, I'm not seeing this problem on a fresh install in a CRA app. Any chance you have a public repro, or can track it down in yours given that it's such a small change? |
|
I just sifted through v3.3.4...v3.3.5 - there is nothing obvious that I can see. I'll do a fresh install with 3.3.4 and see if it is not maybe a transitive dep that causes this. |
|
Yeah, v3.3.5 is a change to a handful of |
|
hmm, it definitely does not happen with |
|
Have you tried nuking |
yes, I am doing |
|
Well, this is weird... 😕 |
|
yes, I might close this and see if someone else opens a similar bug in the next 24h. I will downgrade/stay on 3.3.4 for now. |
|
Please keep us posted, and sorry for the trouble! |
|
Closing for now, watching out for others to report similar problems. Will open again if it is not just me™. |
|
What's your |
|
Even if it's just you, we need to find out why did we broke your setup. Can you please create a GitHub repo with minimal reproduction of your issue? |
|
For the record: We had the same problem after updating from Removing that line made the storybook work again. |
|
I have the same issue updating from I use full control webpack config but I checked and |
I fail to do this :( I am not sure why, but it seems to happen on some machines and not on others. There is no reliable way to reproduce this issue. I wonder if its related to the node version somehow - I am on O and we are using full control mode as well. Is anyone experiencing this without full control mode? |
|
I am not sure why it happens, but I think I found out when it happens (kudos to @gustavohenke). ( |
|
Same for me, I have no error as long as I don't send any request to storybook server. |
|
Ok, in my case, I just had to keep plugins from storybook base config. My bad... |
which plugins? |
|
I was replacing webpack plugins with my owns, overriding the ones set in storybook config ( |
gotcha, hmm, it is hard for me to understand how that would have changed in a minor version update like this one or why we wouldn't have seen this problem before (potentially when upgrading from 3.2 to 3.3?) |
|
Yes, for me the update was from |
Okay, that makes more sense. Maybe in our case the issue was there but noone noticed when we made the 3.2 to 3.3 jump. @shilman @Hypnosphi given the assumption that the culprit is somewhere in the 3.2 to 3.3 jump and the information that it happens on a |
|
@joscha is it still the case that you can't repro this or is it possible now you know the way to make it happen? What does your custom webpack config do? |
|
@joscha yeah, the strict requirement of preservig the default plugins in full control mode appeared in 3.3, since we've added HTML plugins in #1775 It's kinda breaking change in minor release. We have a few of them, and that's definitely not cool. We've revisited our release strategy since then, and I hope it will allow us to follow semver more strictly. |
|
@Hypnosphi If you understand what's going on here, do you mind updating |
|
Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 60 days. Thanks! |
|
Hi everyone. I get this issue. Try to fix, but cannot. Please help me. |
|
@lamkn please have a look here: #2704 (comment) as I think the two issues are related. |
|
@joscha Thank. I followed it already. but the issue still show up. Any more idea? please help |
|
Sorry, that's all I got. The issue disappeared after upgrade and using the
absolute path.
…On Mon., 23 Apr. 2018, 18:36 lamkn, ***@***.***> wrote:
@joscha <https://github.com/joscha> Thank. I followed it already. but the
issue still show up. Any more idea? please help
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2680 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AALehrtXOk4lcz9ky8oh2nMq_6PoeNj7ks5trZKRgaJpZM4RV-_J>
.
|
|
@lamkn, I was experiencing the same issue. Setting |
Issue details
when starting storybook I expect something like:
instead I get:
Steps to reproduce
Upgrade from Storybook
3.3.3(Update: 3.3.4 is fine) 3.3.4 to 3.3.5I am not sure why it happens. The upgrade alone shows the problem, no other code changes needed. I dug around a bit for references to
public/index.html, but can't find an obvious one. Will update the issue once I know more.Please specify which version of Storybook and optionally any affected addons that you're running
The text was updated successfully, but these errors were encountered: