Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build-storybook not exitting when fail #2716

Closed
davidkwan95 opened this issue Jan 11, 2018 · 6 comments
Closed

build-storybook not exitting when fail #2716

davidkwan95 opened this issue Jan 11, 2018 · 6 comments

Comments

@davidkwan95
Copy link
Contributor

davidkwan95 commented Jan 11, 2018

Issue details

Expected behavior: build-storybook should exit when err.
Actual behavior: process is stuck and not exitting

Steps to reproduce

  1. Some fail imports in code
  2. build-storybook

Please specify which version of Storybook and optionally any affected addons that you're running

  • @ storybook/react 3.3.6
  • @ storybook/addon-actions 3.3.6
  • @ storybook/addon-info 3.3.6
  • @ storybook/addon-links 3.3.6

Affected platforms

  • Node v8.9.3
@Hypnosphi
Copy link
Member

Can't reproduce it on fresh CRA

$ npm run build-storybook

> test-app@0.1.0 build-storybook /Users/jetbrains/test-app
> build-storybook -s public

info @storybook/react v3.3.6
info
info => Loading custom addons config.
info => Using default webpack setup based on "Create React App".
info => Copying static files from: public
info Building storybook ...
ERR! Failed to build the storybook
ERR! Module not found: Error: Can't resolve '@stoybook/addon-actions' in '/Users/jetbrains/test-app/src/stories'
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! test-app@0.1.0 build-storybook: `build-storybook -s public`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the test-app@0.1.0 build-storybook script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /Users/jetbrains/.npm/_logs/2018-01-11T10_54_03_281Z-debug.log

@Hypnosphi
Copy link
Member

Can you please create a GitHub repo with minimal reproduction of your issue?

@davidkwan95
Copy link
Contributor Author

I am trying to reproduce it in a new project, but so far I've been unable to reproduce it.

@ohelixa
Copy link

ohelixa commented Mar 28, 2019

I have the same issue

@shilman
Copy link
Member

shilman commented Mar 28, 2019

@ohelixa what version?

@ohelixa
Copy link

ohelixa commented Mar 29, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants